build: support empty libname flags in configure.py#62477
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 30, 2026
Merged
build: support empty libname flags in configure.py#62477nodejs-github-bot merged 1 commit intonodejs:mainfrom
configure.py#62477nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
build
aduh95
changed the title
from-pkg-config for shared lib namesconfigure.py
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
ShogunPanda
approved these changes
Mar 30, 2026
BethGriggs
approved these changes
Mar 30, 2026
aduh95
added
author ready
atlowChemi
approved these changes
Mar 30, 2026
jasnell
approved these changes
Mar 30, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5913aa9 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Mar 30, 2026
PR-URL: nodejs#62477 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, passing e.g.
--shared-sqlite-libname=ends up passing-l''in the lib flags, and there is no way to defer to the pkgconfig ones.